Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0.x] replace .api_secret to .foreign_api_secret #546

Merged
merged 1 commit into from
Dec 16, 2020
Merged

[5.0.x] replace .api_secret to .foreign_api_secret #546

merged 1 commit into from
Dec 16, 2020

Conversation

deevope
Copy link
Contributor

@deevope deevope commented Dec 15, 2020

@deevope deevope mentioned this pull request Dec 15, 2020
Closed
@jaspervdm
Copy link
Contributor

Thanks! Could you PR this against the current/5.0.x branch so we can include it in the next beta and onwards?

@deevope deevope changed the base branch from master to current/5.0.x December 15, 2020 22:42
@deevope
Copy link
Contributor Author

deevope commented Dec 16, 2020

Done! 👌

@antiochp antiochp changed the title replace .api_secret to .foreign_api_secret [5.0.x] replace .api_secret to .foreign_api_secret Dec 16, 2020
@antiochp antiochp added this to the 5.0.0 milestone Dec 16, 2020
@antiochp antiochp mentioned this pull request Dec 16, 2020
Closed
quentinlesceller
quentinlesceller approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested from scratch and works well.

@quentinlesceller quentinlesceller merged commit e956a48 into mimblewimble:current/5.0.x Dec 16, 2020
quentinlesceller pushed a commit to quentinlesceller/grin-wallet that referenced this pull request Mar 5, 2021
@deevope @quentinlesceller
replace .api_secret to .foreign_api_secret (mimblewimble#546)
bd5b537
@quentinlesceller quentinlesceller mentioned this pull request Mar 5, 2021
Merged
@deevope deevope deleted the blade-issue branch December 30, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaspervdm jaspervdm jaspervdm approved these changes

@quentinlesceller quentinlesceller quentinlesceller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@deevope @jaspervdm @quentinlesceller @antiochp